Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Rust reshim #11848

Merged
merged 3 commits into from
Dec 12, 2024
Merged

Add Rust reshim #11848

merged 3 commits into from
Dec 12, 2024

Conversation

ericholscher
Copy link
Member

This is required for Cargo builds,
as I hit here:

https://app.readthedocs.org/projects/test-builds/builds/26564308/

@ericholscher ericholscher requested a review from a team as a code owner December 11, 2024 22:49
@ericholscher ericholscher requested a review from humitos December 11, 2024 22:49
ericholscher added a commit that referenced this pull request Dec 11, 2024
This shows how to host docs with mdbook.

Requires #11848 to not need a reshim
ericholscher added a commit that referenced this pull request Dec 11, 2024
This shows how to host docs with mdbook.

Requires #11848 to not need a reshim
Copy link
Member

@humitos humitos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The concept looks good, but I think the code is not working as expected. Tests and linting are failing as well --I suppose they are related.

readthedocs/doc_builder/director.py Outdated Show resolved Hide resolved
readthedocs/doc_builder/director.py Show resolved Hide resolved
@ericholscher ericholscher merged commit cff4f15 into main Dec 12, 2024
8 checks passed
@ericholscher ericholscher deleted the reshim-rust branch December 12, 2024 18:21
humitos added a commit that referenced this pull request Dec 17, 2024
This shows how to host docs with mdbook.
    
Requires #11848 to
not need a reshim (example:
https://github.com/readthedocs/test-builds/blob/mdbook/.readthedocs.yaml#L10)


<!-- readthedocs-preview docs start -->
---
:books: Documentation previews :books:

- User's documentation (`docs`):
https://docs--11849.org.readthedocs.build/en/11849/

<!-- readthedocs-preview docs end -->

<!-- readthedocs-preview dev start -->
- Developer's documentation (`dev`):
https://dev--11849.org.readthedocs.build/en/11849/

<!-- readthedocs-preview dev end -->

---------

Co-authored-by: Manuel Kaufmann <humitos@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants